From 9fans@cse.psu.edu Thu Oct 19 14:27:07 EDT 1995 Article: 660 of comp.os.plan9 Xref: cannon.ecf comp.os.plan9:660 Newsgroups: comp.os.plan9 Path: cannon.ecf!utnut!cs.utexas.edu!academ!bcm.tmc.edu!news.msfc.nasa.gov!elroy.jpl.nasa.gov!swrinde!sdd.hp.com!vixen.cso.uiuc.edu!uwm.edu!chi-news.cic.net!simtel!news.sprintlink.net!in2.uu.net!EU.net!uknet!dcl-cs!bath.ac.uk!ccsis From: schwartz@plan9.CSe.psu.EDU Subject: (none) Message-ID: <95Oct18.175453edt.78400@colossus.cse.psu.edu> Sender: ccsis@bath.ac.uk (Icarus Sparry) Reply-To: 9fans@cse.psu.edu Organization: Plan 9 mailing list Date: Wed, 18 Oct 1995 13:47:33 GMT Approved: plan9mod@bath.ac.uk Lines: 15 Status: RO I noticed that srv sometimes gives unhelpful error messages. Inspection reveals that there are uninitialized variables due to goto-lossage. Suggested improvement: term% diff srv.c srv.c.orig 74d73 < strcpy(dest, *argv); 90a90,91 > strcpy(dest, *argv); > 124c125 < fprint(2, "srv %s: mount(%s) failed: %s\n", dest, mtpt, err); --- > fprint(2, "srv %s: mount failed: %s\n", dest, err);